fix: Include packed assets in Package Update when asset packaging is …#29
Merged
Conversation
…enabled Fixed an issue where the Package Update button was excluding both the packed assets AND the source files when asset packaging was enabled, resulting in no assets being included in the update package. Changes: - Added check for PackageUpdateAssets preference in createUpdate method - Made editorExcludeDirectories conditional based on packaging settings - When packaging is enabled: includes packs directory, excludes source files - When packaging is disabled: excludes packs directory, excludes pack files - Now matches the behavior of Upload to Server functionality This ensures that when asset packaging is enabled, the packaged assets in the resources/packs directory are included in the update, and the source asset files are excluded (to avoid duplication).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…enabled
Fixed an issue where the Package Update button was excluding both the packed assets AND the source files when asset packaging was enabled, resulting in no assets being included in the update package.
Changes:
This ensures that when asset packaging is enabled, the packaged assets in the resources/packs directory are included in the update, and the source asset files are excluded (to avoid duplication).